Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support configuration of plantUML server #139

Closed
FrVaBe opened this issue Jul 17, 2019 · 2 comments
Closed

support configuration of plantUML server #139

FrVaBe opened this issue Jul 17, 2019 · 2 comments
Labels
enhancement
Milestone
1.4.4

Comments

@FrVaBe
Copy link

FrVaBe commented Jul 17, 2019

Markdown PDF works great but it seems to always use the default plantUML server configured in markdown-it-plantuml. This server only accepts a certain number of requests per document. In documents with a large number of diagrams, not all diagrams are created. Instead, we have this warning in the document:

grafik

The use of an own (local) PlantUML server usually helps here. Therefore this is a feature request to make the Plant UML Server address configurable.

See also a corresponding Issue #12 in the markdown-it-plantuml repository, but I think it is missplaced there and belongs to this project here.
@FrVaBe FrVaBe mentioned this issue Jul 17, 2019
Closed
yzane added a commit that referenced this issue Mar 17, 2020
@yzane
Add: markdown-pdf.plantumlServer option #139
42ecf2b
@yzane yzane added this to the 1.4.4 milestone Mar 17, 2020
@yzane
Copy link
Owner

yzane commented Mar 18, 2020

Please upgrade Markdown PDF to ver1.4.4 and try.

@FrVaBe
Copy link
Author

FrVaBe commented Mar 19, 2020

Thanks @yzane - that works just fine now!

Still looking for a possibility to have a nice preview in VS Code. Even the Markdown Preview Enhanced Plugin does not manage to show plantuml diagrams which are simple given as @startuml ... @enduml code snippets. And the output of the preview looks very different to the pdf output. Thus this is no alternative for me. But that is another story

@FrVaBe FrVaBe closed this as completed Mar 19, 2020
tat3 pushed a commit to tat3/vscode-markdown-pdf-2 that referenced this issue Sep 4, 2022
@yzane
Add: markdown-pdf.plantumlServer option yzane#139
5764dda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@FrVaBe @yzane