Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] getawslog.py - move to boto3, logging, file in memory #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] getawslog.py - move to boto3, logging, file in memory #56

wants to merge 1 commit into from

Conversation

mpucholblasco
Copy link

Changes

  • Moved from boto to boto3
  • Applied logging
  • Files content just handled in memory (no disk writes)
  • Changed content to adapt to pylint
  • Removed count a whole table rows to know if a table exists. Changed by a SELECT 1 FROM table.

Testing

By executing on a cloudtrail bucket.

Incompatibilities

  • Changed options flag -l | --log meaning. Now this flag represents the log output filename. Previous meaning has been moved to -o | --output.

@jesuslinares
Copy link
Contributor

Hi @mpucholblasco,

sorry for the late response. We are working on this script too. We will consider your recommendations.

Thanks very much for your contribution.

@SitoRBJ SitoRBJ changed the base branch from master to 3.7 September 12, 2018 09:43
@Lopuiz Lopuiz changed the base branch from 3.7 to 3.10 June 18, 2019 08:43
@vikman90 vikman90 changed the base branch from 3.10 to develop July 31, 2020 12:13
@vikman90 vikman90 changed the base branch from develop to master September 25, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mpucholblasco @jesuslinares