Allow other Exceptions to bubble up a stack trace instead of silently failing in create_user.py #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello @daxxog Sorry for the late response. Unfortunately, the master/stable/4.3 branches had a structure change, so this PR has conflicts. Thanks a lot and sorry for the inconvenience. |
… failing in create_user.py
|
@alberpilot I have rebased my pull request against current master branch. |
|
@daxxog thanks a lot for your contribution. I will cherry-pick your commit to other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an issue where the
wazuh/wazuh-odfe:4.2.5container would fail with the ambiguous error message:Patching the
create_user.pyfile to not have a blanket catch all exceptions allowed me to find out the real error was (likely file permissions issue):