Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generic Community ID computation API #525

Merged
merged 15 commits into from
Jul 11, 2019
Merged

Implement generic Community ID computation API #525

merged 15 commits into from
Jul 11, 2019

Conversation

mavam
Copy link
Member

@mavam mavam commented Jul 1, 2019

This PR adds a the Community ID to PCAP packet data.

@mavam mavam added the feature New functionality label Jul 1, 2019
@mavam mavam changed the title Add Community ID to PCAP packet data Implement generic Community ID computation API Jul 11, 2019
@mavam mavam marked this pull request as ready for review July 11, 2019 08:16
Neverlord
Neverlord suggested changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@Neverlord Neverlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple of minor suggestions.

libvast/test/community_id.cpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Outdated Show resolved Hide resolved
libvast/vast/community_id.hpp Show resolved Hide resolved
libvast/vast/detail/coding.hpp Outdated Show resolved Hide resolved
libvast/vast/icmp.hpp Outdated Show resolved Hide resolved
libvast/vast/icmp.hpp Outdated Show resolved Hide resolved
libvast/vast/icmp.hpp Outdated Show resolved Hide resolved
libvast/test/hash.cpp Outdated Show resolved Hide resolved
Neverlord
Neverlord suggested changes Jul 11, 2019
View reviewed changes
libvast/vast/format/mrt.hpp Outdated Show resolved Hide resolved
@mavam mavam merged commit e52e56b into master Jul 11, 2019
@mavam mavam deleted the story/ch6424 branch July 11, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neverlord Neverlord Neverlord requested changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
2 participants
@mavam @Neverlord