Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue were a regex match could return nil #19159

Conversation

cgranleese-r7
Copy link
Contributor

Fixes an issue were nil could have been returned when matching a regex for the PostgreSQL version query result.

Verification

  • Ci passes (New test passes)
  • Code changes are sane

@cgranleese-r7 cgranleese-r7 added the rn-fix release notes fix label May 3, 2024
@cgranleese-r7 cgranleese-r7 changed the title Fixes an issue were a regex match could have returnnil Fixes an issue were a regex match could return nil May 3, 2024
@cgranleese-r7 cgranleese-r7 force-pushed the fixes-issue-of-nil-being-returned-from-regex branch from 2df3c6f to c78fd1e Compare May 7, 2024 12:28
lib/postgres/postgres-pr/connection.rb Outdated Show resolved Hide resolved
spec/lib/rex/proto/postgresql/client_spec.rb Outdated Show resolved Hide resolved
@cgranleese-r7 cgranleese-r7 force-pushed the fixes-issue-of-nil-being-returned-from-regex branch from c78fd1e to 3d044c4 Compare May 7, 2024 15:46
@adfoster-r7 adfoster-r7 merged commit 1b9f242 into rapid7:master May 8, 2024
37 checks passed
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented May 8, 2024

Release Notes

Improves the error detection when detecting platform and arch for PostgreSQL session types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants