tsdb: expose hook to customize block querier #14114
Open
+116
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e63bf05
to
d7f9de9
Compare
tjhop
reviewed
May 26, 2024
tsdb/db.go
Outdated
| // BlockQuerierFunc is a function to return storage.Querier from a BlockReader. | ||
| BlockQuerierFunc BlockQuerierFunc | ||
|
|
||
| // BlockQuerierFunc is a function to return storage.ChunkQuerier from a BlockReader. |
There was a problem hiding this comment.
Suggested change
| // BlockQuerierFunc is a function to return storage.ChunkQuerier from a BlockReader. | |
| // BlockChunkQuerierFunc is a function to return storage.ChunkQuerier from a BlockReader. |
bboreham
reviewed
May 27, 2024
tsdb/db.go
Outdated
Comment on lines
253
to
255
| blockQuerierFunc func(b BlockReader, mint, maxt int64) (storage.Querier, error) | ||
|
|
||
| blockChunkQuerierFunc func(b BlockReader, mint, maxt int64) (storage.ChunkQuerier, error) |
There was a problem hiding this comment.
Why don't these use the types defined?
There was a problem hiding this comment.
Make sense. Updated the code.
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
f2d55b8
to
1063814
Compare
|
Thank you @bboreham for the review. Is it ready to be merged or requires another approval? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TSDB, during query time, blocks are only included or pruned based on time range and the logic is controlled in
blockChunkQuerierForRangeanddb.Querierfunction.We want to experiment with different strategies so that Querier can apply additional filtering logic in the hook based on
BlockReader. See the unit test addedTestBlockQuerierAndBlockChunkQuerier. The filtering can be based on metadata from the block.