Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues with multi-thread execution #5187

Merged
merged 12 commits into from
Jun 13, 2024
Merged

Fixing issues with multi-thread execution #5187

merged 12 commits into from
Jun 13, 2024

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented May 15, 2024 •
edited

Proposed changes

Fixing multiple issues during usage as SDK

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Mzack9999 Mzack9999 added the Type: Enhancement Most issues will probably ask for additions or changes. label May 15, 2024
@Mzack9999 Mzack9999 self-assigned this May 15, 2024
This was linked to issues May 15, 2024
Multiple NucleiEngine instances cause HTTP scan failures #5165
Closed
Warn - open /tmp/nuclei_scanner3696466119/000002.log: no such file or directory, while using nuclei library #5162
Closed
@Mzack9999 Mzack9999 changed the title Scheduler Prototype Fixing issues with multi-thread execution May 23, 2024
@Mzack9999 Mzack9999 marked this pull request as ready for review May 23, 2024 07:09
@Mzack9999 Mzack9999 mentioned this pull request May 23, 2024
Closed
ehsandeep
ehsandeep requested changes May 24, 2024
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict

tarunKoyalwar
tarunKoyalwar requested changes May 29, 2024
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

suggested one change about closing shared resources, apart from that i think its time for us to work on possibly removing shared global singletons so i have created a issue to track it #5239

lib/multi.go Outdated Show resolved Hide resolved
@Mzack9999 Mzack9999 merged commit 51b1d7c into dev Jun 13, 2024
12 checks passed
@Mzack9999 Mzack9999 deleted the feat-4808-planner branch June 13, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep requested changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar requested changes

Assignees

@Mzack9999 Mzack9999

Labels
Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
3 participants
@Mzack9999 @ehsandeep @tarunKoyalwar