Use connect-go and connect-web for APIs #1664
Conversation
| * | ||
| * @generated from field: int64 diff = 4; | ||
| */ | ||
| diff = protoInt64.zero; |
There was a problem hiding this comment.
That looks nice, it automatically handles the int64 support: https://github.com/bufbuild/protobuf-es/blob/main/packages/protobuf/src/proto-int64.ts
The config was manual with the other plugin: https://github.com/timostamm/protobuf-ts/blob/master/MANUAL.md#bigint-support
The strict mode PR (#1632) surfaces some potential issues around it, and you might need to handle them, a large comment in the plugin's code seems to explain how
101730e
to
b317f19
Compare
b317f19
to
c39d9e9
Compare
There was a problem hiding this comment.
Exciting to see movement on this PR!
Since we use a couple of gRPC interceptors we need to write these for the time being ourselves. It should be too complex. In fact, for Pyrra I've already started to write an interceptor that creates the known
grpc_server_*andgrpc_client_*metrics.
AFAIK the buf people are working on an Open Telemetry interceptor too. I'll ask them about it.
btw connect-opentelemetry-go has had its first release: https://buf.build/blog/connect-opentelemetry-go
| @@ -12,6 +12,11 @@ plugins: | |||
| out: gen/proto/go | |||
| opt: paths=source_relative | |||
|
|
|||
| # renovate: datasource=github-releases depName=bufbuild/connect-go | |||
| - plugin: connect-go | |||
There was a problem hiding this comment.
Aliases! I'd still pin the version of the plugins to ensure it is reproducible
This was my 20% Friday project and I'll continue.
It makes Parca use Connect which makes creating the Server for both HTTP/JSON and gRPC/protobuf a lot easier.
The Targets page of Parca already works via the newly generated APIs with HTTP/JSON directly.
And some of the Query service APIs also work. This is the most work left, converting the APIs.
Since we use a couple of gRPC interceptors we need to write these for the time being ourselves. It should be too complex. In fact, for Pyrra I've already started to write an interceptor that creates the known
grpc_server_*andgrpc_client_*metrics.AFAIK the buf people are working on an Open Telemetry interceptor too. I'll ask them about it.