-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpack: Update build-id and create debug RPMs #5936
Conversation
@Smjert thoughts on how to fix
|
We may have to set a long directory path for the builds, similar to https://github.com/apple/foundationdb/blob/master/build/cmake/docker-compose.yml#L20 |
Dang, I need to apply the padding for the source (of course!). This might be a little more challenging. |
Looking at what CPackRPM.cmake does, it uses the
Then in the configure step change And so on for all the steps that mention $(Build.SourcesDirectory). Moreover, I see that it will require a tool, EDIT: I've edited the base path where the long source dir is created because the Agent might not be able to create it there if it's using a container. |
62e2b52
to
b5284a8
Compare
Ok, I've reset the PR to remove the changes to Azure. |
Sorry, I think I recalled the issue wrong; it's the submodule that cannot find its correct path. EDIT: Just to clarify, what the CI is doing here is
Not
Which would create the I suggest creating that path and the link starting from the $(Build.BinariesDirectory). |
I'm checking to see if the |
Seems to work; It indeed needs more padding |
Interesting... beyond the openssl macOS failure, it seems that it's also trying to include sources from the build folder.. which it kind of make sense because we have links and some generated files there. |
Also, since this now depends on the presence of |
bd337d1
to
ac5b1dc
Compare
I'm skipping the documentation about package building dependencies for now since they are required by CPack. I am nearly 100% I know what dependencies are needed, as I can read the CPack generator code but that seems a overkill for the information we provide. |
This commit adds
-debuginfo
package builds for the RPM generator. This also updates the--build-id
linker flag to use SHA1 build IDs.