CMake: Migrate macOS and Windows to the OpenSSL formula #5928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8d131ac
to
9b88f23
Compare
theopolis
reviewed
Oct 24, 2019
theopolis
requested changes
Oct 24, 2019
9b88f23
to
c428e64
Compare
This is required to compile OpenSSL using the formula
This is another requirement for the OpenSSL formula
c428e64
to
7c2ea71
Compare
|
We need to update the build documentation to mention the new expectations for Windows: install Perl and Nasm. We might want to give a heads up to the Windows compiler team, whom regularly builds osquery. |
I'm updating the documentation next. I also want to restore the Azure config changes you made in the other PR to show the formula log because it was really useful! |
d0b31e2
to
175a636
Compare
theopolis
approved these changes
Oct 25, 2019
|
Looks good, @alessandrogario, I will let you decide if you want to squash or land the series of individual commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formula should work, but I still have to add a script to install Perl on the Windows CI machineReady for review!