Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve etc_protocols test #5957

Merged
merged 1 commit into from
Oct 29, 2019
Merged

improve etc_protocols test #5957

merged 1 commit into from
Oct 29, 2019

Conversation

f-eiwu
Copy link
Contributor

@f-eiwu f-eiwu commented Oct 28, 2019 •
edited

In the etc_protocols test, the alias field in the etc_protocols table was not allowed to be empty, this caused the test on some machine to fail as described in #5805. Now it's allowed to be empty.

@theopolis theopolis added the test label Oct 29, 2019
@theopolis theopolis merged commit b67736d into osquery:master Oct 29, 2019
@f-eiwu f-eiwu deleted the tests/etc_protocols branch November 1, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f-eiwu @theopolis