Move fuzzing harness to a new directory and refactor fuzzing constants (#5909) #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osquery#5909) This commit creates a new osquery/main/harnesses directory and moves fuzz-config there. It removes OSQUERY_FUZZ for a new option OSQUERY_ENABLE_FUZZER_SANITIZERS It creates a new option OSQUERY_ENABLE_ADDRESS_SANITIZER The following behaviors are intended: BUILD_TESTS=true will build the fuzzing harness This configuration is not intended for fuzzing purposes, just to keep the fuzzing harness compiling ENABLE_FUZZER_SANITIZERS=true will also build the fuzzing harness However if this variable is true, it also requires: ENABLE_ADDRESS_SANITIZER=true CMAKE_BUILD_TYPE=Release or RelWithDebInfo This configuration is actually intended for fuzzing
|
|
theopolis
approved these changes
Oct 20, 2019
|
This will break the oss-fuzz build script temporarily. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #5909
My first foray into cmake so let me know what needs to be changed...
I didn't add Undefined Behavior or Thread sanitizer constants because adding those sanitizers would bloat this commit - these sanitizers will require testing before they can be enabled. (Especially TSAN, which I think has heavy dependency requirements...)