Removing code repetition and fixing timer bug #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
theopolis
requested changes
Oct 15, 2019
|
Heads up that the EasyCLA is reporting a missing signature, is this a bug in EasyCLA? |
theopolis
approved these changes
Oct 18, 2019
|
Thanks @uptycs-nishant, the last thing we need is the CLA to be signed. Once that job passes we can merge. |
|
I have completed the CLA, but it is not getting reflected here. |
|
The trick to fix that is close and reopen the PR. Seems like an ongoing issues we’ll need to investigate. Should be rebuilding now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing some of the issues raised at #5883