-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade SQLite to 3.29.0 on macOS and Windows #5810
Conversation
Mitigates recent CVEs in SQLite. It was already this version on Linux.
We probably ought to change the layer name from |
Layer name has been changed to |
I moved sqlite entirely out of I suppose it might also make sense to remove |
Thanks for looking into this! I suggest to avoid moving or duplicating files, for a matter of maintenance and git history. In pratice: for each library that also supports macOS and Windows, you mirror its CMake files (Findxxx.cmake and its CMakeLists.txt) in the new source_migration folder, but they actually |
183b5be
to
3ab49bd
Compare
Updated as per comment by @Smjert to include the file in the |
The changes look good, though it would be better if the silencing of warnings coming from the third party libraries is reproduced also for Windows. |
I added the warning suppression for Windows as well. This does introduce a new warning due to |
What you mean here? If your intention is to solve the Lines 277 to 293 in 65aca42
This is done so that you can choose to have flags that do not touch third party targets (they inherit only from c_settings and cxx_settings). There you can add /W3 if needed to osquery targets but not to third party ones, and you can keep what you put in this PR.
Or even better, if this is again your "only" issue, is to update the minimum required CMake version to the latest stable. |
Turns out it was all unnecessary anyway... If you just set |
Mitigates recent CVEs in SQLite. It was already this version on Linux.