Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WTSFreeMemoryEx to WTSFreeMemory #5642

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Update WTSFreeMemoryEx to WTSFreeMemory #5642

merged 2 commits into from
Jul 19, 2019

Conversation

directionless
Copy link
Member

@directionless directionless commented Jul 17, 2019 •
edited

Fixes #4655

I don't have much context here, other than the listed bug report. An internet search finds a slightly more in depth blog article http://redplait.blogspot.com/2018/06/interesting-case-of-memory-leak.html

As mentioned, the docs do reference using WTSFreeMemory to free.

Thanks for the bug report redplait

@directionless
Update WTSFreeMemoryEx to WTSFreeMemory
13977d5 
Fixes osquery#4655

I don't have much context here, other than the listed bug report. An
internet search finds a slightly more in depth blog article http://redplait.blogspot.com/2018/06/interesting-case-of-memory-leak.html

As mentioned, the docs do reference using `WTSFreeMemory` to free.

Thanks for the bug report (redplait)[https://github.com/redplait]
@directionless
Copy link
Member Author

directionless commented Jul 17, 2019 •
edited

Let's see what CI says!

@Mossberg @woodruffw I think you're both windows people, what do you think?

muffins
muffins previously approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@muffins muffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Really impressive find there. This lgtm!

@directionless directionless merged commit d10dab8 into osquery:master Jul 19, 2019
@directionless directionless deleted the seph/4655 branch July 19, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theopolis theopolis theopolis approved these changes

@muffins muffins muffins left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leak in genLoggedInUsers
3 participants
@directionless @theopolis @muffins