(Windows) New table: default_environment #5441
Conversation
There was a problem hiding this comment.
Thank you @woodruffw for this contribution!
Just one small question about code changes. Also let me run more tests on it and we good to merge it.
There was a problem hiding this comment.
@akindyakov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@woodruffw has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@akindyakov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@akindyakov has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This has also been rebased and is good for another review (cc @alessandrogario / @theopolis / @Smjert). |
|
We've addressed the CI failure. If you don't mind rebasing onto master, this should fix the issue. |
|
|
||
| namespace osquery { | ||
| namespace tables { | ||
| static std::string kEnvironmentKey = |
Adds the
default_environmenttable, which contains rows of default environment variables added to each process on initialization by Windows.This table proxies and extrapolates its contents from the
registrytable.