Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include weekends on the kernel_panics table #5298

Closed
wants to merge 1 commit into from

Conversation

obelisk
Copy link
Contributor

@obelisk obelisk commented Nov 14, 2018

The set accidentally missed Saturday and Sunday days of the week. This just adds them in.

Fixes #5297.

@facebook-github-bot facebook-github-bot added the cla signed Automated label: Pull Request author has signed the osquery CLA label Nov 14, 2018
@obelisk obelisk self-assigned this Nov 14, 2018
@obelisk
Copy link
Contributor Author

obelisk commented Nov 14, 2018

Fixes #5297

The set accidently missed Saturday and Sunday days of the week. This just adds them in
@packetzero
Copy link
Contributor

clowntown label? 😀

@fmanco fmanco changed the base branch from master to experimental January 16, 2019 11:49
@fmanco fmanco changed the title Fix[#5297] Didn't include weekends in kernel_panics table Include weekends on the kernel_panics table Jan 16, 2019
Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmanco has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmanco is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

muffins pushed a commit to muffins/osquery that referenced this pull request Feb 1, 2019
Summary:
The set accidentally missed Saturday and Sunday days of the week. This just adds them in.

Fixes osquery#5297.
Pull Request resolved: osquery#5298

Reviewed By: guliashvili

Differential Revision: D13690812

Pulled By: fmanco

fbshipit-source-id: 1859d32ad635d63548435fed8e9da131530be5ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cla signed Automated label: Pull Request author has signed the osquery CLA clowntown macOS virtual tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants