chrome_extensions: Add the profile name to the table #5213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akindyakov
reviewed
Sep 14, 2018
| std::string profile_name; | ||
| auto status = getChromeProfileName(profile_name, profile_path); | ||
| if (!status.ok()) { | ||
| LOG(WARNING) << status.getMessage(); |
There was a problem hiding this comment.
May I ask you to add a prefix for this log line? Smth like: "Getting chrome profile name failed: " ?
akindyakov
reviewed
Sep 14, 2018
|
|
||
| const auto& profile_obj = tree.get_child_optional(kProfilePreferenceKey); | ||
| if (!profile_obj) { | ||
| return Status(1, "The following profile is malformed: " + path.string()); |
There was a problem hiding this comment.
Nit: you could use a bit more self descriptive form of creating status with error:
return Status::failure(...);If you like so :)
|
ok to test |
|
Hi @alessandrogario |
|
Hello @guliashvili ! I've updated the PR to target experimental! Thanks for looking into this patch! |
There was a problem hiding this comment.
@guliashvili has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@guliashvili merged this pull request in 507638d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new column to the
chrome_extensionstable namedprofile, used to show the name of the Chrome profile that owns each extension.