Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5737: Add FileVersionRaw column to file table for windows #5771

Merged
merged 3 commits into from
Jul 26, 2020

Conversation

nasehim7
Copy link
Contributor

@nasehim7 nasehim7 commented Sep 7, 2019

I have added the file_version column to the file table for windows. I have used the approach of adding a new parameter to the windowsGetFileVersion(). I have refactored the name of the method as well as the parameters. Here is a blueprint of the same:

/*

  • @brief Get the product and file version associated with a file
  • @param path: Full path to the file
  • @param product_version: String representing the product version, e.g. "16.0.8201.0"
  • @param file_version: String representing the file version
  • @return Success if the version could be retrieved, otherwise failure
    */
    Status windowsGetVersionInfo(const std::string& path, std::string& product_version, std::string& file_version);

I have added the additional field for the fileVersion in the row structure as well as have placed a validation test in the file table.

Tackling issue: #5737

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 7, 2019

CLA Check
The committers are authorized under a signed CLA.

@theopolis theopolis closed this Jul 26, 2020
@theopolis theopolis reopened this Jul 26, 2020
@theopolis theopolis merged commit 6101a0a into osquery:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants