Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

I accepted the CLA

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ok to test

You can run make format_master to fix code audit. Failing FreeBSD should be our problem

Sorry for that, I'd run make format before submitting the PR but it seems I should have used make format_master.

Should I merge two commits in one?

Feel free to push as many commits as you want to. While merging they will be squashed into the single commit

ok to test

To pass FreeBSD rebase is needed on new master

Did rebase

Any chance to have it reviewed?

The committers are authorized under a signed CLA.

• ✅ Eugene Sidorov (353ed7a)
• ✅ Teddy Reed (8122ff6)

Hi @luc-lynx, I really like the idea of having this table in osquery. I rebased this table onto our current master to help get this going again. There's work that still remains, for example reviewing our new CLA, adding the new files to our CMake build, and iterating on a few more code reviews. I am happy to help along the way, let me know if you have time.

Thanks for your message. I'll definitely find time to carry on work on the PR.

Just a little update that I've started to work on that and will get back with some updates shortly.

The Linux jobs fail due to required code-format changes, run: make format_check to see what changes you need to apply.

@theopolis Yes, I'm trying to run it but I'm getting a huge bunch of complains about the code I didn't touch... Do you happen to know how it can be scoped only to my changeset?

@luc-lynx
It's possible to have clang-format itself to format the code, but you need to to have it in the git stage.
Normally you have to format before commiting, if you've already committed then you need to go on every commit you have, put it temporarily in the stage, format it, add the changes (if any) in stage and commit it again.

So this process would be:

git rebase -i <oldest commit of your PR>~1
// mark all commits to be edited, then proceed
git reset --soft HEAD~1 // Removed the commit but keeps the changes in the stage
// now from the build folder
cmake --build . --target format
// if there are changes, back in the source folder
git add <changed files>
// otherwise jump directly here
git commit -C ORIG_HEAD
git rebase --continue
// repeat, back to the git reset

As you can see formatting after the fact is a bit more annoying.
In your case it might be worth to squash all the commits you have now into one, so that you just need to put that into stage, without having to do a rebase, and format it.

@theopolis could you please review the PR?

Thanks for the review, I'll get back with the updates in a week.

@theopolis could you please take a look at my comments in the review?

If builds pass this LGTM

I've fixed imports and spec (turned out it was also missing). Should be fine now.