ci: Correct job order #8185
Merged
ci: Correct job order #8185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_source_code job was waiting for the same job 2 times, while it should've also waited for the code style job. Also add a dependency in the build jobs to the libraries manifest check. The general idea is to have quick checks go first and fail everything immediately if something is wrong.
zwass
approved these changes
Nov 10, 2023
directionless
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_source_code job was waiting for the same job 2 times, while it should've also waited for the code style job.
Also add a dependency in the build jobs to the libraries manifest check. The general idea is to have quick checks go first and fail everything immediately if something is wrong.