logs: Implement decorations_top_level flag for status logs #8102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds support to put the decorations at the root level of the status log JSON. - Remove use of boost ptree to write status logs JSON and use rapidjson, making it consistent with results log. The "line", "unixTime" and "severity" will not be written as strings anymore, since they are numbers. - Add tests to verify standard decorations and custom ones for status logs.
265d613
to
12f512e
Compare
sharvilshah
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Thanks @Smjert! I haven't yet tested this locally, but this broadly looks right..thanks for the detailed tests, those do help! Just a minor update on doc, would be nice to have that new flag added to our docs.
sharvilshah
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to put the decorations at the root level of the status log JSON.
Remove use of boost ptree to write status logs JSON and use rapidjson, making it consistent with results log. The "line", "unixTime" and "severity" will not be written as strings anymore, since they are numbers.
Add tests to verify standard decorations and custom ones for status logs.