core: Avoid checking if a file exists before opening #8087

Smjert · 2023-07-21T15:09:12Z

Checking if a file exists before opening it is a pessimization and susceptible to race conditions.
On posix it's enough to open without O_CREAT and if the file doesn't exists the open will return -1.

Checking if a file exists before opening it is a pessimization and susceptible to race conditions. On posix it's enough to open without O_CREAT and if the file doesn't exists the open will return -1.

core: Avoid checking if a file exists before opening

06715dc

Checking if a file exists before opening it is a pessimization and susceptible to race conditions. On posix it's enough to open without O_CREAT and if the file doesn't exists the open will return -1.

Smjert added macOS Linux performance core labels Jul 21, 2023

Smjert requested review from a team as code owners July 21, 2023 15:09

sharvilshah approved these changes Jul 27, 2023

View reviewed changes

Smjert merged commit b026fd6 into osquery:master Jul 28, 2023
16 checks passed

Smjert deleted the stefano/improvement/avoid-stat-on-file-open branch July 28, 2023 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: Avoid checking if a file exists before opening #8087

core: Avoid checking if a file exists before opening #8087

Smjert commented Jul 21, 2023

core: Avoid checking if a file exists before opening #8087

core: Avoid checking if a file exists before opening #8087

Conversation

Smjert commented Jul 21, 2023