Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove forensicReadFile #8085

Merged

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Jul 20, 2023

The function doesn't do much especially due to relatime or noatime on Linux.
Furthermore even if it did something, it tampers with times and does not prevent an application to read the updated atime.

The function doesn't do much especially due to relatime
or noatime on Linux.
Furthermore even if it did something, it tampers with times
and does not prevent an application to read the updated atime.
@Smjert Smjert added the core label Jul 20, 2023
@Smjert Smjert marked this pull request as ready for review July 21, 2023 12:42
@Smjert Smjert requested review from a team as code owners July 21, 2023 12:42
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've been talking about how forensicRead wasn't useful. Thanks for removing it!

@Smjert Smjert merged commit 0e3f222 into osquery:master Jul 30, 2023
16 checks passed
@Smjert Smjert deleted the stefano/cleanup/remove-forensic-read branch July 30, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants