Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Substitute the TEXT macro with SQL_TEXT in table code #8091

Merged
merged 1 commit into from
Jul 30, 2023
Merged

cleanup: Substitute the TEXT macro with SQL_TEXT in table code #8091

merged 1 commit into from
Jul 30, 2023

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Jul 25, 2023

Don't keep a macro which on Windows cannot be used due to collisions.
Use only one version for clarity.

@Smjert
cleanup: Substitute the TEXT macro with SQL_TEXT in table code
49560df 
Don't keep a macro which on Windows cannot be used due to collisions.
Use only one version for clarity.
@Smjert Smjert force-pushed the stefano/cleanup/sql-conversion-macro branch from 0a71d0c to 49560df Compare July 25, 2023 19:10
@Smjert Smjert marked this pull request as ready for review July 26, 2023 10:51
@Smjert Smjert requested review from a team as code owners July 26, 2023 10:51
@Smjert Smjert merged commit 4dcee81 into osquery:master Jul 30, 2023
16 checks passed
@Smjert Smjert deleted the stefano/cleanup/sql-conversion-macro branch July 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Smjert @directionless