Fix username field in managed_policy table #7944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59e4b4e
to
ad7d41d
Compare
|
Hi folks! We've reproduced this issue in Fleet, see: fleetdm/fleet#8119. I've compiled this branch and tested the fix and it works (username was |
zwass
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Code looks good. Merging with @lucasmrod's confirmation. Thank you @bgirardeau-figma!
|
Nice thanks for the testing and review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the username field in managed_policy table is always set to "." for a user policy. This changes the field to instead be the actual username (or empty if it is a system policy), which is the expected behavior.
The issue is that directory paths from
listDirectoriesInDirectoryend in "/" (see here), which causes their filename and stem to be "." due to the Boost behavior described hereTested manually with a managed machine using osqueryi. Also uncommented the table test, though it doesn't actually test anything on a non-managed machine (ie in CI) because the plist files are not present.