docs: clarify that logger_plugin is set from CLI #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm. The flag is specified as working in a config. I wonder if this is a bug, not a documentation issue |
|
Just an FYI while you're debating that...a previous commit (#7595) removes this same option from another example. See comment: #7595 (comment) |
Oh. I see what you mean -- In #7595 we changed Can you sign the CLA? |
directionless
approved these changes
Jan 20, 2023
|
@directionless signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hello!
Just a quick docs update to the example for AWS logging plugins. I've removed the
logger_pluginfrom config and added clarifications that it must be set via a CLI flag (with a link to those docs).