libs: Fix libmagic build on macOS #7915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only rename strlcat and strlcpy on Linux, otherwise the library will try to use the renamed functions which are not provided by the library anymore.
directionless
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only rename strlcat and strlcpy on Linux,
otherwise the library will try to use the renamed functions which are not provided by the library anymore.
The compilation did not fail on the CI due to linker magic that drops functions that call those strlcat and strlcpy functions. When compiling with ASAN enabled though the callers are not dropped anymore, causing a linking error.