Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the lldp_neighbors table #7664

Merged
merged 1 commit into from
Jul 3, 2022

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Jun 29, 2022

As discussed in the past and in #7463 this deprecates and removes the lldp_neighbors table.

Fixes #7463

@Smjert Smjert added virtual tables deprecation Relating to function deprecation labels Jun 29, 2022
@Smjert Smjert requested review from a team as code owners June 29, 2022 12:23
sharvilshah
sharvilshah previously approved these changes Jun 29, 2022
Copy link
Member

@sharvilshah sharvilshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks @Smjert

@iko1
Copy link
Contributor

iko1 commented Jun 30, 2022

I recommend to try loading the lldpctl.so dynamically, instead of building stactically like the current situaiton, in order to support widely between Linux distributions and versions. I can organize a quick PoC if you find that table is crucial.

@Smjert
Copy link
Member Author

Smjert commented Jun 30, 2022

I recommend to try loading the lldpctl.so dynamically, instead of building stactically like the current situaiton, in order to support widely between Linux distributions and versions. I can organize a quick PoC if you find that table is crucial.

@iko1 Thanks!
As I was mentioning in the other issue, it's not clear to me how stable the interface towards the .so across all the versions of Linux (and lldpd) we have to support is; so there is a risk is that some data structure used by the library to communicate via the API boundary changes between versions, which would mean that we would have to define multiple types.

So I would prefer to go forward with the removal, also because again the table was broken since a lot of time and we didn't heard complains about it.
If a better implementation is found, it can be later readded.

@Smjert
Copy link
Member Author

Smjert commented Jun 30, 2022

@sharvilshah @alessandrogario my bad, I forgot to delete the library folder (libraries/cmake/source/lldpd)

@Smjert Smjert merged commit e295cc3 into osquery:master Jul 3, 2022
@Smjert Smjert deleted the stefano/deprecate/lldp branch July 3, 2022 16:04
@iko1 iko1 mentioned this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Relating to function deprecation virtual tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the unreliable table lldp_neighbors
4 participants