Update shared_resources table to add type names, fix type/maximum_allowed handling
#7645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3085f70
to
b1f6124
Compare
shared_resources table to add type names, fix type/maximum_allowed handling
directionless
approved these changes
Jun 24, 2022
Comment on lines
+30
to
+31
| {3, "IPC"}, | ||
| {2147483648, "Disk Drive Admin"}, |
There was a problem hiding this comment.
:eyeroll: so what happened to the other numbers. Ha.
There was a problem hiding this comment.
:eyeroll: so what happened to the other numbers. Ha.
It is strange! I haven't found a define for it in the documentation, so I ended up using the raw numbers
| row["allow_maximum"] = INTEGER(status.ok() ? allow_maximum : -1); | ||
|
|
||
| long raw_maximum_allowed_value{}; | ||
| status = wmi_item.GetLong("MaximumAllowed", raw_maximum_allowed_value); |
There was a problem hiding this comment.
I'm fine either way. But does it even make sense to populate this field if AllowMaximum is set?
There was a problem hiding this comment.
I was about to go down the same route, but I noticed that this field is always populated and retrieved correctly regardless of what AllowMaximum has been set to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.