Improve config parsing and osqueryfuzz-config performance #7635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #7636 |
- Speed up config parsing in stripConfigComments by using string_view to avoid unnecessary and slow string copies - Speed up osqueryfuzz-config by periodically resetting the custom flags map - Lower the chances of an OOM by periodically resetting the options config parser state, since it grows incrementally each time it parses new options. Also call malloc_trim.
59dab9b
to
6acd79f
Compare
directionless
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up config parsing in stripConfigComments by using string_view
to avoid unnecessary and slow string copies
Speed up osqueryfuzz-config by periodically resetting
the custom flags map
Lower the chances of an OOM by periodically resetting
the options config parser state, since it grows incrementally
each time it parses new options. Also call malloc_trim.
Related to #7634