Fix system-info support for Unicode characters on Windows #7626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The computer_name and local_hostname columns where incorrectly truncating Unicode characters when the computer name contained them. Use the WinAPI to get the computer name instead of the POSIX one, which correctly supports Unicode. - Minor cleanup on the getHostname implementation of Linux and macOS too, since POSIX guarantees the same max size.
fc6a0f2
to
046e849
Compare
directionless
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computer_name and local_hostname columns where incorrectly
truncating Unicode characters when the computer name contained them.
Use the WinAPI to get the computer name instead of the POSIX one,
which correctly supports Unicode.
Minor cleanup on the getHostname implementation of Linux and macOS too,
since POSIX guarantees the same max size.
On Windows this can be tested by:
system_infowith osquery pre and post this patch