Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Docker build scripts and configuration #7619

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Add Docker build scripts and configuration #7619

merged 2 commits into from
Jun 10, 2022

Conversation

zwass
Copy link
Member

@zwass zwass commented Jun 7, 2022

No description provided.

@zwass zwass requested review from a team as code owners June 7, 2022 00:04
@zwass
Add Docker build scripts and configuration
a079ba1 
This configuration is already used to push the images to the Docker
osquery/osquery repository.
directionless
directionless approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

I suspect there's some interesting things that could happen to do this in a big single shot multistage docker file. But this looks like it should work, and we could not get too fancy.

@Smjert
Copy link
Member

Smjert commented Jun 7, 2022 •
edited

@zwass thanks for this!
This branch needs to be rebased on a newer master where the readthedocs fix is present.

@Smjert Smjert merged commit 70156f8 into osquery:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
build test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zwass @Smjert @directionless @mike-myers-tob