Use additional instead of index for admindir in deb_packages #7573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although both index and additional add the column to the primary key, index is meant to mark columns that make the row unique. So the column values should contain unique values. additional instead marks a column that when provided in a where clause changes the table behvior, which is more correct in this case, since the packages will be parsed from a different path than the default.
f89bdcf
to
14a1159
Compare
alessandrogario
approved these changes
Apr 26, 2022
sharvilshah
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although both index and additional add the column to the primary key,
index is meant to mark columns that make the row unique.
So the column values should contain unique values.
additional instead marks a column that when provided in a where clause
changes the table behvior, which is more correct in this case,
since the packages will be parsed from a different path than the default.