Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the section where the users and groups service flags are described #7596

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented May 19, 2022

Related to #7516

@Smjert Smjert requested review from a team as code owners May 19, 2022 15:41
@Smjert Smjert added this to the 5.3.0 milestone May 19, 2022
@mike-myers-tob
Copy link
Member

This just moves some of the wiki text under a different heading, is that right?

@Smjert
Copy link
Member Author

Smjert commented May 19, 2022

This just moves some of the wiki text under a different heading, is that right?

Yes! I messed up the location.

@Smjert Smjert force-pushed the stefano/docs/correct-user-groups-section branch from 4da1469 to 935edfa Compare May 19, 2022 16:12
@Smjert
Copy link
Member Author

Smjert commented May 19, 2022

I've now also slightly updated the start of the description, to remove the redundant "Windows only flag...", and also fix one of the numeric values that was incorrectly including also the ms suffix.

@mike-myers-tob
Copy link
Member

LGTM

@directionless directionless merged commit 7f0f543 into osquery:master May 24, 2022
@mike-myers-tob mike-myers-tob deleted the stefano/docs/correct-user-groups-section branch May 25, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants