Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libs: Update libdpkg from version v1.19.0.5 to v1.21.7 #7549

Merged
merged 1 commit into from
Apr 15, 2022
Merged

libs: Update libdpkg from version v1.19.0.5 to v1.21.7 #7549

merged 1 commit into from
Apr 15, 2022

Conversation

alessandrogario
Copy link
Member

@alessandrogario alessandrogario commented Apr 5, 2022 •
edited by mike-myers-tob

  • Update the library libdpkg
  • Make the libdpkg error handling more resilient
  • Refactor of the deb_packages table
  • Adds a column to the deb_packages table that makes the admin directory configurable instead of hardcoded to /usr/local/var/lib/dpkg

@alessandrogario alessandrogario added Linux libraries For things referring to osquery third party libraries cmake pure cmake changes labels Apr 5, 2022
@alessandrogario alessandrogario force-pushed the alessandro/cmake/update-libdpkg-to-v1.21.7 branch 8 times, most recently from b3c2e59 to 59f6ab2 Compare April 8, 2022 13:15
@alessandrogario alessandrogario marked this pull request as ready for review April 8, 2022 13:15
@alessandrogario alessandrogario requested review from a team as code owners April 8, 2022 13:15
@alessandrogario alessandrogario force-pushed the alessandro/cmake/update-libdpkg-to-v1.21.7 branch from 59f6ab2 to 37e708a Compare April 8, 2022 17:48
@mike-myers-tob mike-myers-tob added the ready for review Pull requests that are ready to be reviewed by a maintainer label Apr 8, 2022
directionless
directionless previously approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but the code seems fine

osquery/tables/system/linux/deb_packages.cpp Outdated Show resolved Hide resolved
osquery/tables/system/linux/deb_packages.cpp Show resolved Hide resolved
@alessandrogario
libs: Update libdpkg from version v1.19.0.5 to v1.21.7
b7636c3 
deb_packages: Rewrite the table for libdpkg v1.21.7

deb_packages: Add support for setting the dpkg admindir

deb_packages: Refactor

deb_packages: Continue with the next admindir on error

deb_packages: Fix error handler using the wrong Expected var

deb_packages: Provide more descriptive error messages

deb_packages: Update the integration test
@alessandrogario alessandrogario force-pushed the alessandro/cmake/update-libdpkg-to-v1.21.7 branch from 37e708a to b7636c3 Compare April 15, 2022 10:49
@mike-myers-tob mike-myers-tob merged commit ae421a9 into osquery:master Apr 15, 2022
@mike-myers-tob mike-myers-tob deleted the alessandro/cmake/update-libdpkg-to-v1.21.7 branch April 15, 2022 17:17
@Smjert Smjert mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
cmake pure cmake changes libraries For things referring to osquery third party libraries Linux ready for review Pull requests that are ready to be reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alessandrogario @directionless @mike-myers-tob