Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unmaintainable legacy table, smart_drive_info #7542

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Deprecate unmaintainable legacy table, smart_drive_info #7542

merged 3 commits into from
Apr 29, 2022

Conversation

iko1
Copy link
Contributor

@iko1 iko1 commented Apr 2, 2022

Fixes #7464

@iko1 iko1 requested review from a team as code owners April 2, 2022 16:17
@iko1 iko1 force-pushed the deprecate-smart-drive-info branch from d0fe326 to 1ad3016 Compare April 2, 2022 16:45
@mike-myers-tob mike-myers-tob added libraries For things referring to osquery third party libraries dependency deprecation Relating to function deprecation labels Apr 12, 2022
@mike-myers-tob
Copy link
Member

Looks like a good removal to me, @Smjert should we approve and merge the change for 5.3?

@mike-myers-tob mike-myers-tob added the ready for review Pull requests that are ready to be reviewed by a maintainer label Apr 27, 2022
@mike-myers-tob mike-myers-tob merged commit c5b8bfa into osquery:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
deprecation Relating to function deprecation libraries For things referring to osquery third party libraries ready for review Pull requests that are ready to be reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate unmaintainable legacy table, smart_drive_info
3 participants
@iko1 @mike-myers-tob @directionless