Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update librpm to 4.17.0 #7529

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Update librpm to 4.17.0 #7529

merged 1 commit into from
Mar 29, 2022

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Mar 23, 2022

Fixes #7511

@Smjert Smjert added Linux libraries For things referring to osquery third party libraries labels Mar 23, 2022
@Smjert Smjert requested review from a team as code owners March 23, 2022 21:35
@Smjert Smjert added the ready for review Pull requests that are ready to be reviewed by a maintainer label Mar 24, 2022
directionless
directionless approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I don't wholly understand whether we can drop the local patches or not

Does this have any bearing on #7298 or #7422 ?

@Smjert
Copy link
Member Author

Smjert commented Mar 25, 2022 •
edited

Seems fine. I don't wholly understand whether we can drop the local patches or not
The remove-lua.patch is there because we don't want to depend on Lua and link against it. It's a dependency we don't use because we only read and don't want to execute anything.
Previously the build system was providing a flag to disable it and it would set a preprocessor define to compile out the Lua parts, now they have removed that.

For the revert patch the original motivation is here: #6850

I have verified that osquery is able to read the rpm packages information with this new version without that patch on a CentOS 6, but I kept it so that it would not attempt to open dbs we don't need to parse.

Does this have any bearing on #7298 or #7422 ?

Not really, I haven't investigated the hang, or the feasibility of dynamically verifying the presence of getauxval.
I have only tested on two extremes, CentOS 6 and Fedora 35.

@mike-myers-tob mike-myers-tob merged commit ac9fda3 into osquery:master Mar 29, 2022
@mike-myers-tob mike-myers-tob deleted the stefano/libraries/rpm-update-4.17.0 branch March 29, 2022 17:23
alessandrogario pushed a commit to trailofbits/osquery that referenced this pull request Apr 5, 2022
@Smjert @alessandrogario
Update librpm to 4.17.0 (osquery#7529)
4d77c92
aikuchin pushed a commit to aikuchin/osquery that referenced this pull request Jul 11, 2023
@mogrein
Merge pull request osquery#24 in CLOUD/osquery from sync/osquery-5.2.…
9b71df7 
…3 to master

* commit '35edba4e8627f883dc6394f60a7fff60a5a39353':
  libs: Update OpenSSL from version 1.1.1l to 1.1.1n (osquery#7506)
  Drop shortcut_files table (osquery#7547)
  Drop the ssdeep library and remove its hash support  (osquery#7525)
  libs: Update zlib from v1.2.11 to v1.2.12 (osquery#7548)
  Remove libelfin and elf parsing tables (osquery#7524)
  Update librpm to 4.17.0 (osquery#7529)
  libs: Update expat from version 2.2.10 to 2.4.7 (osquery#7526)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
libraries For things referring to osquery third party libraries Linux ready for review Pull requests that are ready to be reviewed by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update librpm dependency
3 participants
@Smjert @directionless @mike-myers-tob