Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore some release checks #7558

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Restore some release checks #7558

merged 1 commit into from
Apr 25, 2022

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Apr 11, 2022 •
edited

  • Permit to better control which arguments are passed
    to python tests

  • Verify that there's no dynamic link
    outside standard system libraries folders
    on Linux and Darwin

  • Verify that there's no unwanted linked library
    on Linux and Windows

  • Split the query pack test in it's own test script,
    since it depends on osquery test framework,
    and still requires some work

Related to #5795
Depends on #7557

@Smjert Smjert added test CI/CD Anything about the Continuous Integration or Continuous Deployment tool used by the repository labels Apr 11, 2022
@Smjert Smjert force-pushed the stefano/test/release-tests branch from b3af91b to bed3065 Compare April 13, 2022 18:07
@Smjert
Restore some release checks
0ec384d 
- Permit to better control which arguments are passed
  to python tests

- Verify that there's no dynamic link
  outside standard system libraries folders
  on Linux and Darwin

- Verify that there's no unwanted linked library
  on Linux and Windows

- Split the query pack test in it's own test script,
  since it depends on osquery test framework,
  and still requires some work
@Smjert Smjert force-pushed the stefano/test/release-tests branch from bed3065 to 0ec384d Compare April 13, 2022 18:57
@Smjert Smjert marked this pull request as ready for review April 13, 2022 20:21
@Smjert Smjert requested review from a team as code owners April 13, 2022 20:21
@mike-myers-tob mike-myers-tob added the ready for review Pull requests that are ready to be reviewed by a maintainer label Apr 19, 2022
directionless
directionless approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Smjert Smjert merged commit e06610a into osquery:master Apr 25, 2022
@Smjert Smjert deleted the stefano/test/release-tests branch April 25, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

@lhmzhou lhmzhou lhmzhou approved these changes

Assignees
No one assigned
Labels
CI/CD Anything about the Continuous Integration or Continuous Deployment tool used by the repository ready for review Pull requests that are ready to be reviewed by a maintainer test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Smjert @directionless @lhmzhou @mike-myers-tob