Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some warnings about unrecognized special characters #7478

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Fix some warnings about unrecognized special characters #7478

merged 1 commit into from
Feb 17, 2022

Conversation

Smjert
Copy link
Member

@Smjert Smjert commented Feb 9, 2022 •
edited

The backslash path separator has to be escaped too in a string,
otherwise it gets decoded with the next character as a special
character.

The warnings:

windows_eventlog_tests.cpp(41): warning C4129: 'A': unrecognized character escape sequence
windows_eventlog_tests.cpp(41): warning C4129: 'D': unrecognized character escape sequence
windows_eventlog_tests.cpp(41): warning C4129: 'w': unrecognized character escape sequence
windows_eventlog_tests.cpp(41): warning C4129: 'o': unrecognized character escape sequence
windows_eventlog_tests.cpp(42): warning C4129: 'o': unrecognized character escape sequence
windows_eventlog_tests.cpp(42): warning C4129: 'D': unrecognized character escape sequence
windows_eventlog_tests.cpp(43): warning C4129: 'W': unrecognized character escape sequence
windows_eventlog_tests.cpp(43): warning C4129: 'S': unrecognized character escape sequence

@Smjert
Fix some warnings about unrecognized special characters
8deb3c2 
The backslash path separator has to be escaped too in a string,
otherwise it gets decoded with the next character as a special
character.
@Smjert Smjert requested review from a team as code owners February 9, 2022 11:07
@Smjert Smjert added the Windows label Feb 9, 2022
@Smjert Smjert merged commit 8abdf50 into osquery:master Feb 17, 2022
@Smjert Smjert deleted the stefano/build/event-log-test-warnings branch February 17, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
build test Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Smjert @directionless