Add utc flag back for compatibility
#7460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharvilshah
reviewed
Jan 25, 2022
There was a problem hiding this comment.
While I'm generally game for some breaking changes, this presents something of a coupling issue. If one wanted utc timestamps, but needed an osquery config to work across multiple versions, there's no way to do it. So, this adds the flag back as a
HIDDEN_FLAG. (Not sure we have a better pattern for this)
I think this is reasonable approach
(needs clang-format)
ddb31d5
to
825d938
Compare
sharvilshah
approved these changes
Jan 26, 2022
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…2 to master * commit 'c97a1b416492585e049010deea36d2992b680556': (52 commits) Fix user_time and system_time unit in processes table on M1 (osquery#7473) Add BOOST_USE_ASAN define when enabling Asan (osquery#7469) Removing unnecessary macOS version check (osquery#7451) Add `utc` flag back for compatibility(osquery#7460) Add osquery version to macOS app bundle Info.plist (osquery#7452) Fix submodule cache for macOS CI runner (osquery#7456) New Table: Windows Firewall Rules (osquery#7403) Remove utc flag from example config file (osquery#7437) Update the ATC table `path` column check to be case insensitive (osquery#7442) Fix typos in documentation (osquery#7443) Fix a crash when Yara uses its own strutils functions (osquery#7439) Update `time` table to reflect UTC values (osquery#7276) Update sqlite to version 3.37.0 (osquery#7426) Fix linking of thirdparty_sleuthkit (osquery#7425) Apple Silicon support (osquery#7330) Fix how we disable tables in the fuzzer init method (osquery#7419) Prevent running discovery queries when fuzzing (osquery#7418) Hide the deprecate `antispyware` column in `windows_security_center` (osquery#7411) Fix typo in docs (osquery#7412) CHANGELOG 5.1.0 (osquery#7406) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7276 we removed the functionality of the
--utcflag. Unfortunately, we also removed the flag. This causes osquery to break on older configurations.While I'm generally game for some breaking changes, this presents something of a coupling issue. If one wanted utc timestamps, but needed an osquery config to work across multiple versions, there's no way to do it. So, this adds the flag back as a
HIDDEN_FLAG. (Not sure we have a better pattern for this)