[AWS] Support custom endpoints for Kinesis and Firehose. #7317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @OlegOAndreev ! Good to see a new contributor. There's a documentation page about the AWS logging plugin here https://osquery.readthedocs.io/en/latest/deployment/aws-logging/ It's generated from this file: https://github.com/osquery/osquery/blob/master/docs/wiki/deployment/aws-logging.md Do you think you could add some brief documentation of the new flags, to your PR? |
|
Thanks for the quick reply! I've mentioned the new flags in the docs and fixed the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
--aws_firehose_endpointand--aws_kinesis_endpointflags to support non-AWS Kinesis and Firehose implementations. Setting the flag disables AWS region validation.