Always initialize variable change in PerformanceChange
#7176
Conversation
|
|
641f3db
to
bdc2289
Compare
osquery/core/watcher.cpp
Outdated
| change.footprint = 0; | ||
| change.parent = 0; |
There was a problem hiding this comment.
Why not do all 4 members?
There was a problem hiding this comment.
change.iv and change.sustained_latency are initialized on line 409/447.
There was a problem hiding this comment.
I'd rather be consistent and initialize everything early, one way is to add a constructor to the structure or use the initializer-list form {0} for the member definitions. Or just set the other two members = 0 here.
osquery/core/watcher.cpp
Outdated
| change.footprint = 0; | ||
| change.parent = 0; |
There was a problem hiding this comment.
I'd rather be consistent and initialize everything early, one way is to add a constructor to the structure or use the initializer-list form {0} for the member definitions. Or just set the other two members = 0 here.
|
I have changed the code to initialize them in the first place. |
change
changechange in PerformanceChange
This PR initializes
parentandfootprintof variablechangeright after it is declared, in case they are not initialized when an exception is thrown. (When control reaches line 422)