Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chrome_extensions: Compute the identifier from the 'key' property #7124

Merged
merged 1 commit into from
May 27, 2021
Merged

chrome_extensions: Compute the identifier from the 'key' property #7124

merged 1 commit into from
May 27, 2021

Conversation

alessandrogario
Copy link
Member

@alessandrogario alessandrogario commented May 25, 2021 •
edited

Changes

  • The identifier column now contains the identifier built from the key property of the extension manifest.
  • The identifier used in the Preferences/Secure Preferences profile to reference extensions is now stored in the referenced_identifier column.

Fixes: #7093

@alessandrogario alessandrogario requested review from a team as code owners May 25, 2021 15:25
@alessandrogario alessandrogario linked an issue May 25, 2021 that may be closed by this pull request
chrome_extensions not reporting identifier for unreferenced extensions #7093
Closed
@alessandrogario alessandrogario force-pushed the alessandro/feature/compute-chrome-extension-identifiers branch 3 times, most recently from 5656f6d to a6d242f Compare May 25, 2021 16:37
directionless
directionless reviewed May 25, 2021
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for implementing this. I can't really comment on the c++ side

Thoughts about column names?

specs/chrome_extensions.table Outdated Show resolved Hide resolved
@alessandrogario alessandrogario force-pushed the alessandro/feature/compute-chrome-extension-identifiers branch from a6d242f to 88742fc Compare May 26, 2021 09:54
@alessandrogario alessandrogario force-pushed the alessandro/feature/compute-chrome-extension-identifiers branch from 88742fc to e51c3ba Compare May 26, 2021 10:25
@theopolis theopolis merged commit 2ac2be7 into osquery:master May 27, 2021
@alessandrogario alessandrogario deleted the alessandro/feature/compute-chrome-extension-identifiers branch May 29, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless left review comments

@theopolis theopolis theopolis approved these changes

Assignees

@directionless directionless

Labels
feature virtual tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chrome_extensions not reporting identifier for unreferenced extensions
3 participants
@alessandrogario @directionless @theopolis