Improve shutdown speed during initialization #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interrupt the extension plugin initialization retry loop as soon as the request to shutdown is received. Also attempt to avoid doing any additional work along the path of initialization.
|
What about focusing on the For example, instead of checking |
theopolis
requested changes
May 23, 2021
| @@ -224,6 +225,10 @@ std::string RegistryFactory::getActive(const std::string& registry_name) const { | |||
| } | |||
|
|
|||
| void RegistryFactory::setUp() { | |||
| if (shutdownRequested()) { | |||
There was a problem hiding this comment.
Does the check at https://github.com/osquery/osquery/pull/7106/files#diff-691b47a21b0ad765c31fe03b547baf942a06cd3c6ce5770a11997bec3c7d9977R567 immediately proceed this one?
osquery/events/eventfactory.cpp
Outdated
| @@ -427,6 +428,10 @@ void EventFactory::delay() { | |||
| return; | |||
| } | |||
|
|
|||
| if (shutdownRequested()) { | |||
There was a problem hiding this comment.
Could you combine this check and the check in attachEvents into a single check within Initializer::start?
theopolis
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interrupt the extension plugin initialization retry loop
as soon as the request to shutdown is received.
Also attempt to avoid doing any additional work along the path
of initialization.
Related to #7068