Fix extensions crash on shutdown #7075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crash was happening due to the ExtensionWatcher thread still running and attempting to call the watch() function, while the extension was exiting. Use the Initializer::shutdown() function so that all threads/services are stopped before exiting. Also update the documentation with the example extension.
d277123
to
4599ae6
Compare
theopolis
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crash was happening due to the ExtensionWatcher thread still running
and attempting to call the watch() function,
while the extension was exiting.
Use the Initializer::shutdown() function so that all threads/services are stopped before
exiting.
Also update the documentation with the example extension.