Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add a security assurance case #7048

Merged
merged 13 commits into from
Jul 13, 2021

Conversation

mike-myers-tob
Copy link
Member

@mike-myers-tob mike-myers-tob commented Apr 8, 2021

Closes #7047

Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps not the main thrust here, but I think SECURITY.md is probably the wrong file for this sort of posture & best practices doc.

I think SECURITY.md is more oriented to practical question, like "how do I report an issue"

github has this to say:

I could see combining them into something larger

SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@theopolis
Copy link
Member

I am happy to contribute more here and there if we can land a v1. I don't think we need to have this be completed before merging. But we should have something more than just the headings (e.g., we should implement the feedback thus far).

@mike-myers-tob mike-myers-tob changed the title WIP: Docs: add a security assurance case Docs: add a security assurance case Jun 8, 2021
@mike-myers-tob mike-myers-tob marked this pull request as ready for review June 8, 2021 02:49
@mike-myers-tob mike-myers-tob requested review from a team as code owners June 8, 2021 02:49
ASSURANCE.md Outdated Show resolved Hide resolved
@mike-myers-tob
Copy link
Member Author

Friendly ping -- is there any feedback I can still address or can we merge this as v1?

@theopolis
Copy link
Member

This is great! Thanks @mike-myers-tob for codifying a lot of institutional understanding as well as iterating on feedback. Let's consider this a v1 and be open to more conversation and proposed changes going forward.

@theopolis theopolis merged commit a768e4a into osquery:master Jul 13, 2021
@mike-myers-tob mike-myers-tob deleted the mike/docs-security-assurance branch July 14, 2021 00:13
sharvilshah pushed a commit to sharvilshah/osquery that referenced this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Security Assurance guide for osquery
3 participants