Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting non-required deb_packages fields as optional in test #7001

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

timothybritton
Copy link
Contributor

@timothybritton timothybritton commented Mar 12, 2021

section and priority fields are optional in the Debian spec, so valid packages can cause this test to fail.

Debian docs: https://www.debian.org/doc/debian-policy/ch-controlfields.html#binary-package-control-files-debian-control

This is a failure caused by a legitimate package that installs just fine, but has no section:

   96: [----------] 1 test from DebPackages
   96: [ RUN      ] DebPackages.test_sanity
   96: /opt/build/osquery/tests/integration/tables/helper.cpp:167: Failure
   96: Value of: validate_value_using_flags(value, flags)
   96:   Actual: false
   96: Expected: true
   96: Standard validator of the column "section" with value "" failed
   96: Row: {arch: "amd64", maintainer: "Maintainer", name: "package name", priority: "optional", revision: "", section: "", size: "61921", source: "", status: "install ok installed", version: "0.11.0"}
   96: select *, pid_with_namespace, mount_namespace_id from deb_packages
   96: /opt/build/osquery/tests/integration/tables/helper.cpp:167: Failure
   96: Value of: validate_value_using_flags(value, flags)
   96:   Actual: false
   96: Expected: true
   96: Standard validator of the column "section" with value "" failed
   96: Row: {arch: "amd64", maintainer: "Maintainer", mount_namespace_id: "", name: "package name", pid_with_namespace: "0", priority: "optional", revision: "", section: "", size: "61921", source: "", status: "install ok installed", version: "0.11.0"}
   96: [  FAILED  ] DebPackages.test_sanity (44 ms)
   96: [----------] 1 test from DebPackages (44 ms total)

@timothybritton timothybritton requested review from a team as code owners March 12, 2021 17:18
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 12, 2021

CLA Signed

The committers are authorized under a signed CLA.

@theopolis theopolis added flaky test A unit test that sometimes or on some systems does not return success, when it should Linux labels Mar 12, 2021
@directionless directionless merged commit c4016ec into osquery:master Mar 13, 2021
@directionless directionless added the CI/CD Anything about the Continuous Integration or Continuous Deployment tool used by the repository label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Anything about the Continuous Integration or Continuous Deployment tool used by the repository flaky test A unit test that sometimes or on some systems does not return success, when it should Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants