Add build_aarch64 workflow for push #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not intentional, perhaps an oversight. Let me test and see what happens if I add the container logic to the workflow. |
|
Here are the proposed changes from the initial review: https://github.com/theopolis/osquery-ci-test/pull/5/files it looks like the container usage/addition is working as expected. This makes sense because I prepared the AMI with Docker support according to the documentation. |
|
I think I'm happy enough with the code in https://github.com/theopolis/osquery-ci-test/pull/5 want to pull that here and then merge? |
AGSaidi
reviewed
Mar 25, 2021
|
Heads up, once this is approved, I'll add the needed secrets before merging. |
|
... I wonder, what if? |
|
Testing this in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new GitHub Actions workflow called
build_aarch64. This workflow does not run on Pull Requests because non-collaborators do not have access to thesecretscontext, meaning the builds will always fail. This is acceptable for now since we are looking to go from not knowing if aarch64 is working to knowing if it works onmaster. This gives us confidence when tagging new releases that aarch64 tests are passing, and we will have testable packages.In the future we want to have tests run on PRs and https://github.com/osquery/infrastructure/pull/7/files is exploring the solution.
This uses the approach here: https://github.com/machulav/ec2-github-runner but using my fork
theopolis/ec2-github-runner@mainfor a little extra safety from breaking changes (and because I added aarch64 support but will PR this soon).