Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegen: Include extended schema platforms in website json #7760

Merged
merged 1 commit into from
Sep 14, 2022
Merged

codegen: Include extended schema platforms in website json #7760

merged 1 commit into from
Sep 14, 2022

Conversation

artemist-work
Copy link
Contributor

@artemist-work artemist-work commented Sep 2, 2022 •
edited

At Fleet we would like to be able to include platforms on extended schema updates in our web interface (see fleetdm/fleet#7236). This PR changes how the platforms field works in extended_schema and includes them in the output of genwebsitejson.py

@artemist-work artemist-work requested review from a team as code owners September 2, 2022 16:18
@mike-myers-tob mike-myers-tob added feature ready for review Pull requests that are ready to be reviewed by a maintainer core website labels Sep 6, 2022
directionless
directionless approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I can easily test this, but the code eyeballs fine, and I think y'all are on top of improvements here.

@mike-myers-tob mike-myers-tob removed the ready for review Pull requests that are ready to be reviewed by a maintainer label Sep 13, 2022
@directionless directionless mentioned this pull request Sep 14, 2022
Open
@directionless directionless merged commit b0d8f28 into osquery:master Sep 14, 2022
@mike-myers-tob mike-myers-tob mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
feature website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@artemist-work @directionless @mike-myers-tob